linux-kernel - Re: [PATCH 3/3] phy: rockchip: Add Samsung HDMI/DP Combo PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba848de7-1a20-47ee-9013-10500eb3da00@collabora.com>
Date: Wed, 24 Jan 2024 02:24:35 +0200
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Andy Yan <andy.yan@...k-chips.com>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>, Rob Herring
 <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
 Heiko Stuebner <heiko@...ech.de>, Philipp Zabel <p.zabel@...gutronix.de>,
 Johan Jonker <jbx6244@...il.com>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Algea Cao <algea.cao@...k-chips.com>
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH 3/3] phy: rockchip: Add Samsung HDMI/DP Combo PHY driver

Hi Andy,

On 1/22/24 12:17, Andy Yan wrote:
> Hi Cristian:
> 
> On 1/20/24 03:38, Cristian Ciocaltea wrote:
>> Add driver for the Rockchip HDMI/eDP TX Combo PHY found on RK3588 SoC.

[...]

>> +static int rockchip_hdptx_phy_power_on(struct phy *phy)
>> +{
>> +    struct rockchip_hdptx_phy *hdptx = phy_get_drvdata(phy);
>> +    int bus_width = phy_get_bus_width(hdptx->phy);
>> +    int bit_rate = bus_width & DATA_RATE_MASK;
>> +    int ret;
>> +
>> +    dev_dbg(hdptx->dev, "%s bus_width=%x rate=%d\n",
>> +        __func__, bus_width, bit_rate);
>> +
>> +    ret = pm_runtime_resume_and_get(hdptx->dev);
>> +    if (ret) {
>> +        dev_err(hdptx->dev, "Failed to resume phy: %d\n", ret);
>> +        return ret;
>> +    }
>> +
>> +    if (bus_width & HDMI_EARC_MASK)
>> +        hdptx->earc_en = true;
>> +    else
>> +        hdptx->earc_en = false;
>> +
>> +    if (bus_width & HDMI_MODE_MASK) {
> 
> Here use phy->attrs.bus_width to indicate different work mode,
> we also use the same in our bsp, but not sure if it is the appropriate way.

Unfortunately the PHY API doesn't seem to provide a clean way to pass
arbitrary data.  Probably for the initial support we could simply drop
the 10-bit color depth, FRL and EARC features.

Thanks,
Cristian