linux-kernel - Re: Re: [PATCH v2] kunit: Mark filter* params as rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Jan 2024 11:49:43 +0800
From: David Gow <davidgow@...gle.com>
To: Lucas De Marchi <lucas.demarchi@...el.com>
Cc: Rae Moar <rmoar@...gle.com>, linux-kernel@...r.kernel.org, 
	Brendan Higgins <brendan.higgins@...ux.dev>, linux-kselftest@...r.kernel.org, 
	"intel-xe@...ts.freedesktop.org" <intel-xe@...ts.freedesktop.org>, kunit-dev@...glegroups.com
Subject: Re: Re: [PATCH v2] kunit: Mark filter* params as rw

On Wed, 24 Jan 2024 at 00:31, Lucas De Marchi <lucas.demarchi@...el.com> wrote:
>
> On Tue, Jan 23, 2024 at 04:01:49PM +0800, David Gow wrote:
> >On Tue, 23 Jan 2024 at 01:14, Lucas De Marchi <lucas.demarchi@...el.com> wrote:
> >>
> >> By allowing the filter_glob parameter to be written to, it's possible to
> >> tweak the testsuites that will be executed on new module loads. This
> >> makes it easier to run specific tests without having to reload kunit and
> >> provides a way to filter tests on real HW even if kunit is builtin.
> >> Example for xe driver:
> >>
> >> 1) Run just 1 test
> >>         # echo -n xe_bo > /sys/module/kunit/parameters/filter_glob
> >>         # modprobe -r xe_live_test
> >>         # modprobe xe_live_test
> >>         # ls /sys/kernel/debug/kunit/
> >>         xe_bo
> >>
> >> 2) Run all tests
> >>         # echo \* > /sys/module/kunit/parameters/filter_glob
> >>         # modprobe -r xe_live_test
> >>         # modprobe xe_live_test
> >>         # ls /sys/kernel/debug/kunit/
> >>         xe_bo  xe_dma_buf  xe_migrate  xe_mocs
> >>
> >> For completeness and to cover other use cases, also change filter and
> >> filter_action to rw.
> >>
> >> Link: https://lore.kernel.org/intel-xe/dzacvbdditbneiu3e3fmstjmttcbne44yspumpkd6sjn56jqpk@vxu7sksbqrp6/
> >> Reviewed-by: Rae Moar <rmoar@...gle.com>
> >> Signed-off-by: Lucas De Marchi <lucas.demarchi@...el.com>
> >> ---
> >
> >This looks good to me, and works here.
> >
> >Reviewed-by: David Gow <davidgow@...gle.com>
>
> are you going to merge this through kunit tree or should I carry it in
> drm ?
>

I think we'll merge it via KUnit for 6.9, but if you need it sooner, I
doubt it'd cause problems if it went in via DRM instead.

-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4014 bytes)