| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Jan 2024 09:13:09 +0100 From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de> To: Baoquan He <bhe@...hat.com>, linux-kernel@...r.kernel.org Cc: kexec@...ts.infradead.org, x86@...nel.org, linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, linux-mips@...r.kernel.org, linux-riscv@...ts.infradead.org, loongarch@...ts.linux.dev, akpm@...ux-foundation.org, ebiederm@...ssion.com, hbathini@...ux.ibm.com, piliu@...hat.com, viro@...iv.linux.org.uk Subject: Re: [PATCH linux-next v3 10/14] sh, crash: wrap crash dumping code into crash related ifdefs Hello Baoquan, On Wed, 2024-01-24 at 13:12 +0800, Baoquan He wrote: > Now crash codes under kernel/ folder has been split out from kexec > code, crash dumping can be separated from kexec reboot in config > items on SuperH with some adjustments. > > wrap up crash dumping codes with CONFIG_CRASH_DUMP ifdeffery, and > use IS_ENABLED(CONFIG_CRASH_RESERVE) check to decide if compiling > in the crashkernel reservation code. Comparing this to the patches, it seems you missed the first word "Here". Either amend that or write the word "wrap" capitalized. I would omit "Here" as it's not necessary and just start the sentence with "Wrap". Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Powered by blists - more mailing lists