linux-kernel - Re: [linus:master] [mm] 8d59d2214c: vm-scalability.throughput -36.6% regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJD7tkYdvnOhj4a_mzx-w9Zzx8Eg8zFjQxi2+kxR0hD05b3GTg@mail.gmail.com>
Date: Wed, 24 Jan 2024 01:11:59 -0800
From: Yosry Ahmed <yosryahmed@...gle.com>
To: Oliver Sang <oliver.sang@...el.com>
Cc: oe-lkp@...ts.linux.dev, lkp@...el.com, linux-kernel@...r.kernel.org, 
	Andrew Morton <akpm@...ux-foundation.org>, Johannes Weiner <hannes@...xchg.org>, 
	Domenico Cerasuolo <cerasuolodomenico@...il.com>, Shakeel Butt <shakeelb@...gle.com>, 
	Chris Li <chrisl@...nel.org>, Greg Thelen <gthelen@...gle.com>, 
	Ivan Babrou <ivan@...udflare.com>, Michal Hocko <mhocko@...nel.org>, 
	Michal Koutny <mkoutny@...e.com>, Muchun Song <muchun.song@...ux.dev>, 
	Roman Gushchin <roman.gushchin@...ux.dev>, Tejun Heo <tj@...nel.org>, 
	Waiman Long <longman@...hat.com>, Wei Xu <weixugc@...gle.com>, cgroups@...r.kernel.org, 
	linux-mm@...ck.org, ying.huang@...el.com, feng.tang@...el.com, 
	fengwei.yin@...el.com
Subject: Re: [linus:master] [mm] 8d59d2214c: vm-scalability.throughput -36.6% regression

On Wed, Jan 24, 2024 at 12:26 AM Oliver Sang <oliver.sang@...el.com> wrote:
>
> hi, Yosry Ahmed,
>
> On Mon, Jan 22, 2024 at 11:42:04PM -0800, Yosry Ahmed wrote:
> > > > Oliver, would you be able to test if the attached patch helps? It's
> > > > based on 8d59d2214c236.
> > >
> > > the patch failed to compile:
> > >
> > > build_errors:
> > >   - "mm/memcontrol.c:731:38: error: 'x' undeclared (first use in this function)"
> >
> > Apologizes, apparently I sent the patch with some pending diff in my
> > tree that I hadn't committed. Please find a fixed patch attached.
>
> the regression disappears after applying the patch.
>
> Tested-by: kernel test robot <oliver.sang@...el.com>

Awesome! Thanks for testing. I will formalize the patch and send it
out for review.