linux-kernel - Re: [PATCH 1/2] printk: nbcon: move locked_port flag to struct uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Jan 2024 10:53:10 +0106
From: John Ogness <john.ogness@...utronix.de>
To: Junxiao Chang <junxiao.chang@...el.com>, bigeasy@...utronix.de,
 tglx@...utronix.de, rostedt@...dmis.org, linux-kernel@...r.kernel.org
Cc: hao3.li@...el.com, lili.li@...el.com, jianfeng.gao@...el.com,
 linux-rt-users@...r.kernel.org
Subject: Re: [PATCH 1/2] printk: nbcon: move locked_port flag to struct
 uart_port

On 2024-01-23, Junxiao Chang <junxiao.chang@...el.com> wrote:
> Console pointer in uart_port might be shared among multiple uart
> ports.

I still want to investigate why the pointer is shared. This sounds
sloppy or dangerous.

> Flag port locked by nbcon should be saved in uart_port
> structure instead of in console structure.

If it turns out that the pointer sharing is necessary, this patch will
fix the reported problem.

Reviewed-by: John Ogness <john.ogness@...utronix.de>