linux-kernel - Re: [PATCH 14/42] drivers/platform/mellanox: Convert snprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ddc2cc6-1f9c-09c0-acf6-93fa39a10540@linux.intel.com>
Date: Wed, 24 Jan 2024 13:01:05 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Li Zhijian <lizhijian@...itsu.com>
cc: LKML <linux-kernel@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>, 
    Vadim Pasternak <vadimp@...dia.com>, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 14/42] drivers/platform/mellanox: Convert snprintf to
 sysfs_emit

On Tue, 16 Jan 2024, Li Zhijian wrote:

> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
> 
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
> 
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:466:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:584:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:635:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:686:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:737:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:788:8-16: WARNING: please use sysfs_emit
> > ./drivers/platform/mellanox/mlxbf-bootctl.c:839:8-16: WARNING: please use sysfs_emit
> 
> No functional change intended
> 
> CC: Hans de Goede <hdegoede@...hat.com>
> CC: ilpo.jarvinen@...ux.intel.com
> CC: Vadim Pasternak <vadimp@...dia.com>
> CC: platform-driver-x86@...r.kernel.org
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>

Applied to pdx86 review-ilpo branch.

-- 
 i.