linux-kernel - Re: [PATCH][next] platform/x86: thinkpad_acpi: remove redundant assignment to variable i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170609412156.14220.14891875070775431708.b4-ty@linux.intel.com>
Date: Wed, 24 Jan 2024 13:02:01 +0200
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Henrique de Moraes Holschuh <hmh@....eng.br>, 
 Hans de Goede <hdegoede@...hat.com>, ibm-acpi-devel@...ts.sourceforge.net, 
 platform-driver-x86@...r.kernel.org, 
 Colin Ian King <colin.i.king@...il.com>
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] platform/x86: thinkpad_acpi: remove redundant
 assignment to variable i

On Sat, 06 Jan 2024 15:47:40 +0000, Colin Ian King wrote:

> The variable i is being initialized with the value 0 that is never
> read, it is being re-assigned 0 again in a for-loop statement later
> on. The initialization is redundant and can be removed.
> 
> The initialization of variable n can also be deferred after the
> sanity check on pointer n and the declaration of all the int variables
> can be combined as a final code clear-up.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: remove redundant assignment to variable i
      commit: 214509e5d61d294193b220f397418e76879f74c0

--
 i.