linux-kernel - 回复: 回复: [PATCH v4] selftests/landlock:Fix two build issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <381b0dd202074938b527c5b27c86c34f@h3c.com>
Date: Wed, 24 Jan 2024 01:54:52 +0000
From: Huyadi <hu.yadi@....com>
To: 'Mickaël Salaün' <mic@...ikod.net>
CC: "jmorris@...ei.org" <jmorris@...ei.org>,
        "serge@...lyn.com"
	<serge@...lyn.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>,
        "amir73il@...il.com" <amir73il@...il.com>,
        "brauner@...nel.org"
	<brauner@...nel.org>,
        "avagin@...gle.com" <avagin@...gle.com>,
        "linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-security-module@...r.kernel.org"
	<linux-security-module@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>,
        "514118380@...com" <514118380@...com>,
        "konstantin.meskhidze@...wei.com" <konstantin.meskhidze@...wei.com>
Subject: 回复: 回复: [PATCH v4] selftests/landlock:Fix two build issues


>On Tue, Jan 23, 2024 at 12:04:17PM +0000, Huyadi wrote:
>> 
>> >> Changes v3 -> v2:
>> >>  - add helper of gettid instead of __NR_gettid
>> >>  - add gcc/glibc version info in comments Changes v1 -> v2:
>> >>  - fix whitespace error
>> >>  - replace SYS_gettid with _NR_gettid
>> >> 
>> >>  tools/testing/selftests/landlock/fs_test.c  | 5 ++++- 
>> >> tools/testing/selftests/landlock/net_test.c | 7 ++++++-
>> >>  2 files changed, 10 insertions(+), 2 deletions(-)
>> >> 
>> >> diff --git a/tools/testing/selftests/landlock/fs_test.c
>> >> b/tools/testing/selftests/landlock/fs_test.c
>> >> index 18e1f86a6234..a992cf7c0ad1 100644
>> >> --- a/tools/testing/selftests/landlock/fs_test.c
>> >> +++ b/tools/testing/selftests/landlock/fs_test.c
>> >> @@ -4572,7 +4572,10 @@ FIXTURE_VARIANT(layout3_fs)
>> >>  /* clang-format off */
>> >>  FIXTURE_VARIANT_ADD(layout3_fs, tmpfs) {
>> >>  	/* clang-format on */
>> >> -	.mnt = mnt_tmp,
>> >> +	.mnt = {
>> >> +		.type = "tmpfs",
>> >> +		.data = "size=4m,mode=700",
>> >> +	},
>> >
>> >I requested some changes here.
>> >
>> 
>> Could you give me some inspiration how to fix it? 
>> it looks fine to me to assign value as above, which consistent with other pseudo FS tests.
>> Thanks in advance.
>
>Just add and use this for the two tmpfs data:
>#define MNT_TMP_DATA "size=4m,mode=700"
>
>You can also make the mnt_tmp variable static const.


static const is not useful for the case, the errot still, and I'll use macro definition to solve it.
thanks your warmly instruction,I'll send next version , please help to review it.


> 
> >>  	.file_path = file1_s1d1,
> >>  };
> >> 
>