linux-kernel - Re: [PATCH 1/1] platform/x86/intel/ifs: Remove unnecessary ret init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbJ8gp47CWDDqCb4@a4bf019067fa.jf.intel.com>
Date: Thu, 25 Jan 2024 07:21:38 -0800
From: Ashok Raj <ashok.raj@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: Jithu Joseph <jithu.joseph@...el.com>, Tony Luck <tony.luck@...el.com>,
	Hans de Goede <hdegoede@...hat.com>, <platform-driver-x86@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Ashok Raj <ashok.raj@...el.com>
Subject: Re: [PATCH 1/1] platform/x86/intel/ifs: Remove unnecessary ret init

Hi Ilpo

thanks for looking into it.

On Thu, Jan 25, 2024 at 03:03:28PM +0200, Ilpo Järvinen wrote:
> ret variable is assigned unconditionally in ifs_load_firmware(), thus
> remove the unnecessary initialization of it.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  drivers/platform/x86/intel/ifs/load.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
> index a1ee1a74fc3c..03e49b836a6b 100644
> --- a/drivers/platform/x86/intel/ifs/load.c
> +++ b/drivers/platform/x86/intel/ifs/load.c
> @@ -383,7 +383,7 @@ int ifs_load_firmware(struct device *dev)
>  	unsigned int expected_size;
>  	const struct firmware *fw;
>  	char scan_path[64];
> -	int ret = -EINVAL;
> +	int ret;
>  

Looks reasonable to me. 

I can keep this as a separate cleanup patch, or merge the change in this
patch.

What ever Hans/You prefer. 

Cheers,
Ashok