linux-kernel - Re: [PATCH] pidfd: cleanup the usage of __pidfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240125-kilometer-erwischen-9077030e4326@brauner>
Date: Thu, 25 Jan 2024 17:34:50 +0100
From: Christian Brauner <brauner@...nel.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Christian Brauner <brauner@...nel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Tycho Andersen <tandersen@...flix.com>,
	Tycho Andersen <tycho@...ho.pizza>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] pidfd: cleanup the usage of __pidfd_prepare's flags

On Thu, 25 Jan 2024 17:17:34 +0100, Oleg Nesterov wrote:
> - make pidfd_create() static.
> 
> - Don't pass O_RDWR | O_CLOEXEC to __pidfd_prepare() in copy_process(),
>   __pidfd_prepare() adds these flags unconditionally.
> 
> - Kill the flags check in __pidfd_prepare(). sys_pidfd_open() checks the
>   flags itself, all other users of pidfd_prepare() pass flags = 0.
> 
> [...]

Thanks!

---

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] pidfd: cleanup the usage of __pidfd_prepare's flags
      https://git.kernel.org/vfs/vfs/c/2502da713861