linux-kernel - 回复: [PATCH v1 2/2] irqchip: Add StarFive external interrupt controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 03:16:34 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Philipp Zabel <p.zabel@...gutronix.de>, Thomas Gleixner
	<tglx@...utronix.de>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>
CC: Leyfoon Tan <leyfoon.tan@...rfivetech.com>, Jack Zhu
	<jack.zhu@...rfivetech.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject:
 回复: [PATCH v1 2/2] irqchip: Add StarFive external interrupt controller

Hi Philipp,

> On Mi, 2024-01-10 at 18:32 -0800, Changhuang Liang wrote:
> >[...]
> > +	irqc->rst = of_reset_control_get_by_index(intc, 0);
> 
> Please use of_reset_control_get_exclusive(intc, NULL) instead.
> 
> > +	if (IS_ERR(irqc->rst)) {
> > +		pr_err("Unable to get reset control\n");
> > +		ret = PTR_ERR(irqc->rst);
> 
> Consider printing the error code via %pe.
> 
> 

Thanks for your comments. Follow your advice, will change in next version.

regards
Changhuang