linux-kernel - Re: [PATCH v9 09/27] KVM: x86: Rename kvm_{g,s}et

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbHY/UVpRVRuyELV@chao-email>
Date: Thu, 25 Jan 2024 11:43:57 +0800
From: Chao Gao <chao.gao@...el.com>
To: Yang Weijiang <weijiang.yang@...el.com>
CC: <seanjc@...gle.com>, <pbonzini@...hat.com>, <dave.hansen@...el.com>,
	<kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <x86@...nel.org>,
	<yuan.yao@...ux.intel.com>, <peterz@...radead.org>,
	<rick.p.edgecombe@...el.com>, <mlevitsk@...hat.com>, <john.allen@....com>
Subject: Re: [PATCH v9 09/27] KVM: x86: Rename kvm_{g,s}et_msr() to menifest
 emulation operations

On Tue, Jan 23, 2024 at 06:41:42PM -0800, Yang Weijiang wrote:
>Rename kvm_{g,s}et_msr() to kvm_emulate_msr_{read,write}() to make it
>more obvious that KVM uses these helpers to emulate guest behaviors,
>i.e., host_initiated == false in these helpers.
>
>Suggested-by: Sean Christopherson <seanjc@...gle.com>
>Signed-off-by: Yang Weijiang <weijiang.yang@...el.com>
>Reviewed-by: Maxim Levitsky <mlevitsk@...hat.com>

I think {kvm,emulator}_{g,s}et_msr_with_filter are equally confusing.
Maybe you can rename them as well.

Anyway, this patch looks good;

Reviewed-by: Chao Gao <chao.gao@...el.com>