linux-kernel - Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 20:52:02 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc: lee@...nel.org, broonie@...nel.org, patches@...nsource.cirrus.com, 
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes

On Thu, Jan 25, 2024 at 12:25 PM Charles Keepax
<ckeepax@...nsource.cirrus.com> wrote:
>
> Use more forward declarations, move header guards to cover other
> includes, and rely less on including headers through other headers.

..

> Changes since v2:
>  - Added pm.h and regmap.h back into mfd/cs42l43.h

Btw, TIL that your v1 was fully correct as there is no use of the type
definitions. In case you are going to send v3, you can use v1 of this
patch if you want, this version is also okay (as we have some more
like this pattern, which probably needs to be amended in the future).

-- 
With Best Regards,
Andy Shevchenko