lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 25 Jan 2024 08:50:01 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Ding, Shenghao" <shenghao-ding@...com>,
 "broonie@...nel.org" <broonie@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "robh+dt@...nel.org" <robh+dt@...nel.org>,
 "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
 "Lu, Kevin" <kevin-lu@...com>, "Xu, Baojun" <baojun.xu@...com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "lgirdwood@...il.com" <lgirdwood@...il.com>, "perex@...ex.cz"
 <perex@...ex.cz>,
 "pierre-louis.bossart@...ux.intel.com"
 <pierre-louis.bossart@...ux.intel.com>,
 "13916275206@....com" <13916275206@....com>,
 "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
 "soyer@....hu" <soyer@....hu>, "Huang, Jonathan" <jkhuang3@...com>,
 "tiwai@...e.de" <tiwai@...e.de>, "Djuandi, Peter" <pdjuandi@...com>,
 "McPherson, Jeff" <j-mcpherson@...com>,
 "Navada Kanyana, Mukund" <navada@...com>
Subject: Re: [EXTERNAL] Re: [PATCH v1 4/4] ASoc: dt-bindings: Create yaml file
 for pcm6240 codec driver

On 25/01/2024 08:39, Ding, Shenghao wrote:
>>
>> Why do you repeat the reg constraints? This does not seem needed.
>>
>>> +        interrupts: false
>>> +
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - ti,pcm3140
>>> +              - ti,pcm5140
>>> +              - ti,pcm6140
>>> +              - ti,pcmd3180
>>> +    then:
>>> +      properties:
>>> +        reg:
>>> +          description:
>>> +            I2C address, in multiple pcmdevices case, all the i2c address
>>> +            aggregate as one Audio Device to support multiple audio slots.
>>> +          maxItems: 4
>>> +          minItems: 1
>>

You did not respond to any of other comments, therefore I assume you
agree with them 100% and you will implement them fully.


>> Drop entire if
> How to convey ti,pcm1690 does not support interrupt, and others support if I remove this if

How? There is no pcm1690 here.

BTW, add missing line breaks, especially before next blocks like
additionalProperties.

>>
>>> +          items:
>>> +            minimum: 0x4c
>>> +            maximum: 0x4f
>>> +
> 
> BR
> Shenghao Ding
> 

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ