linux-kernel - Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 16:36:16 +0800
From: Kunwu Chan <chentao@...inos.cn>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
 "mpe@...erman.id.au" <mpe@...erman.id.au>,
 "npiggin@...il.com" <npiggin@...il.com>,
 "aneesh.kumar@...nel.org" <aneesh.kumar@...nel.org>,
 "naveen.n.rao@...ux.ibm.com" <naveen.n.rao@...ux.ibm.com>
Cc: "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
 "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver

On 2024/1/24 21:01, Christophe Leroy wrote:
> 
> 
> Le 24/01/2024 à 10:36, Kunwu Chan a écrit :
>> This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
>> in about 14 years before.
>> If there are no plans to enable this part code in the future,
>> we can remove this dead code.
>>
>> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
>> ---
>>    arch/powerpc/kvm/book3s.c | 3 ---
>>    1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
>> index 8acec144120e..c2f50e04eec8 100644
>> --- a/arch/powerpc/kvm/book3s.c
>> +++ b/arch/powerpc/kvm/book3s.c
>> @@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
>>    		break;
>>    	}
>>    
>> -#if 0
>> -	printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
>> -#endif
> 
> Please also remove one of the two blank lines.
Thanks for your reply. I've send the v2 patch:
https://lore.kernel.org/all/20240125082637.532826-1-chentao@kylinos.cn/
https://lore.kernel.org/all/20240125083348.533883-1-chentao@kylinos.cn/
>>    
>>    	if (deliver)
>>    		kvmppc_inject_interrupt(vcpu, vec, 0);
-- 
Thanks,
   Kunwu