linux-kernel - Re: [PATCH] media: i2c: isl7998x: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 09:43:02 +0100
From: Michael Tretter <m.tretter@...gutronix.de>
To: Bo Liu <liubo03@...pur.com>
Cc: kernel@...gutronix.de, mchehab@...nel.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c: isl7998x: convert to use maple tree register
 cache

On Tue, 16 Jan 2024 22:09:10 -0500, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>

Reviewed-by: Michael Tretter <m.tretter@...gutronix.de>

> ---
>  drivers/media/i2c/isl7998x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c
> index 89e13ebbce0c..c7089035bbc1 100644
> --- a/drivers/media/i2c/isl7998x.c
> +++ b/drivers/media/i2c/isl7998x.c
> @@ -1337,7 +1337,7 @@ static const struct regmap_config isl7998x_regmap = {
>  	.rd_table	= &isl7998x_readable_table,
>  	.wr_table	= &isl7998x_writeable_table,
>  	.volatile_table	= &isl7998x_volatile_table,
> -	.cache_type	= REGCACHE_RBTREE,
> +	.cache_type	= REGCACHE_MAPLE,
>  };
>  
>  static int isl7998x_mc_init(struct isl7998x *isl7998x)
> -- 
> 2.31.1
> 
>