linux-kernel - Re: [PATCH 2/3] dt-bindings: phy: Add Rockchip HDMI/DP Combo PHY schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18f66108-98e7-49b3-b362-880121438fc6@linaro.org>
Date: Thu, 25 Jan 2024 10:11:58 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
 Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Philipp Zabel <p.zabel@...gutronix.de>, Johan Jonker <jbx6244@...il.com>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Andy Yan <andy.yan@...k-chips.com>,
 Algea Cao <algea.cao@...k-chips.com>
Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH 2/3] dt-bindings: phy: Add Rockchip HDMI/DP Combo PHY
 schema

On 19/01/2024 20:38, Cristian Ciocaltea wrote:
> +    soc {
> +      #address-cells = <2>;
> +      #size-cells = <2>;
> +
> +      hdptxphy_grf: syscon@...e0000 {
> +        compatible = "rockchip,rk3588-hdptxphy-grf", "syscon";
> +        reg = <0x0 0xfd5e0000 0x0 0x100>;
> +      };

Drop node, not part of this binding.

> +
> +      hdptxphy: phy@...60000 {

Drop label.

> +        compatible = "rockchip,rk3588-hdptx-phy";
> +        reg = <0x0 0xfed60000 0x0 0x2000>;
> +        clocks = <&cru CLK_USB2PHY_HDPTXRXPHY_REF>, <&cru PCLK_HDPTX0>;
> +        clock-names = "ref", "apb";

With these two changes:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof