linux-kernel - Re: [PATCH 3/3] crypto: scompress: remove memcpy if sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbIwqFJ/uBvG2SQf@gondor.apana.org.au>
Date: Thu, 25 Jan 2024 17:58:00 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Barry Song <21cnbao@...il.com>
Cc: davem@...emloft.net, akpm@...ux-foundation.org, ddstreet@...e.org,
	sjenning@...hat.com, vitaly.wool@...sulko.com,
	linux-crypto@...r.kernel.org, chriscli@...gle.com,
	chrisl@...nel.org, hannes@...xchg.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, nphamcs@...il.com, yosryahmed@...gle.com,
	zhouchengming@...edance.com, Barry Song <v-songbaohua@...o.com>
Subject: Re: [PATCH 3/3] crypto: scompress: remove memcpy if sg_nents is 1

On Wed, Jan 03, 2024 at 10:50:06PM +1300, Barry Song wrote:
>
> +	if (dst != scratch->dst)
> +		kunmap_local(dst);

This is missing a flush_dcache_page.

It may not matter for zswap, but this is API code and needs to
work for every single case.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt