linux-kernel - include/linux/dev_printk.h:110:2: warning: '%s' directive argument is null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 18:32:48 +0800
From: kernel test robot <lkp@...el.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: include/linux/dev_printk.h:110:2: warning: '%s' directive argument
 is null

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6098d87eaf31f48153c984e2adadf14762520a87
commit: af628aae8640c268938a0c9344b4ec0d102c0a0a device.h: move dev_printk()-like functions to dev_printk.h
date:   4 years, 1 month ago
config: x86_64-randconfig-012-20240106 (https://download.01.org/0day-ci/archive/20240125/202401251824.Vie9Sa4X-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240125/202401251824.Vie9Sa4X-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401251824.Vie9Sa4X-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/input/mouse/synaptics.c: In function 'synaptics_process_packet':
   drivers/input/mouse/synaptics.c:1103:6: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
    1103 |      ;   /* Nothing, treat a pen as a single finger */
         |      ^
   In file included from include/linux/device.h:15,
                    from include/linux/input.h:19,
                    from include/linux/input/mt.h:11,
                    from drivers/input/mouse/synaptics.c:26:
   drivers/input/mouse/synaptics.c: In function 'synaptics_init_ps2':
>> include/linux/dev_printk.h:110:2: warning: '%s' directive argument is null [-Wformat-overflow=]
     110 |  _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/input/mouse/psmouse.h:202:2: note: in expansion of macro 'dev_info'
     202 |  dev_info(&(psmouse)->ps2dev.serio->dev,  \
         |  ^~~~~~~~
   drivers/input/mouse/synaptics.c:1628:3: note: in expansion of macro 'psmouse_info'
    1628 |   psmouse_info(psmouse,
         |   ^~~~~~~~~~~~


vim +110 include/linux/dev_printk.h

    91	
    92	/*
    93	 * #defines for all the dev_<level> macros to prefix with whatever
    94	 * possible use of #define dev_fmt(fmt) ...
    95	 */
    96	
    97	#define dev_emerg(dev, fmt, ...)					\
    98		_dev_emerg(dev, dev_fmt(fmt), ##__VA_ARGS__)
    99	#define dev_crit(dev, fmt, ...)						\
   100		_dev_crit(dev, dev_fmt(fmt), ##__VA_ARGS__)
   101	#define dev_alert(dev, fmt, ...)					\
   102		_dev_alert(dev, dev_fmt(fmt), ##__VA_ARGS__)
   103	#define dev_err(dev, fmt, ...)						\
   104		_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
   105	#define dev_warn(dev, fmt, ...)						\
   106		_dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
   107	#define dev_notice(dev, fmt, ...)					\
   108		_dev_notice(dev, dev_fmt(fmt), ##__VA_ARGS__)
   109	#define dev_info(dev, fmt, ...)						\
 > 110		_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
   111	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki