linux-kernel - Re: [PATCH v3] dt-bindings: fpga: Convert fpga-region binding to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 25 Jan 2024 12:47:31 +0100
From: Michal Simek <michal.simek@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Rob Herring <robh@...nel.org>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
 git@...inx.com, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Moritz Fischer <mdf@...nel.org>, Tom Rix <trix@...hat.com>,
 Wu Hao <hao.wu@...el.com>, Xu Yilun <yilun.xu@...el.com>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "open list:FPGA MANAGER FRAMEWORK" <linux-fpga@...r.kernel.org>
Subject: Re: [PATCH v3] dt-bindings: fpga: Convert fpga-region binding to yaml



On 1/25/24 12:02, Krzysztof Kozlowski wrote:
> On 20/01/2024 00:32, Rob Herring wrote:
>> On Thu, Jan 18, 2024 at 01:34:16PM +0100, Michal Simek wrote:
>>>
>>>
>>> On 1/17/24 22:47, Rob Herring wrote:
>>>> On Wed, Jan 17, 2024 at 12:30:58PM +0100, Michal Simek wrote:
> 
>>
>>>>> +additionalProperties: true
>>>>
>>>> Why? This should only be used if another schema is going to include this
>>>> one. That's not the case here.
>>>
>>> In v2 we discussed this with Krzysztof. I used pattern properties from
>>> simple-bus.yaml in v2.
>>>
>>> https://lore.kernel.org/all/b2dd8bcd-1e23-4b68-b7b7-c01b034fc1fe@linaro.org/
>>
>> You didn't answer his question. You just picked up
>> 'additionalProperties: true' which is easy because it avoids 'problems'.
>>
>> His question was is this a common schema referenced by other schemas? If
>> so, then use 'additionalProperties: true'. But it is not. You've
>> defined exactly what 'compatible' must be and that means it can't be a
>> common schema.
> 
> Yes, I missed that it has a compatible, so it is not expected to be
> referenced from other schema, thus it should end with
> 'additionalProperties: false'.

I think out of listed properties only nodes with and without regs can be 
present. The only thing is how to encode it.
Do you have any suggestion how to describe it?

Thanks,
Michal