linux-kernel - Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f87bfec-8369-4aa7-abdb-da3593f33051@quicinc.com>
Date: Thu, 25 Jan 2024 17:26:13 +0530
From: Umang Chheda <quic_uchheda@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley
	<conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Kamal Wadhwa
	<quic_kamalw@...cinc.com>
Subject: Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for
 PM7250B PMIC

Hi Konrad,

On 1/25/2024 3:15 PM, Konrad Dybcio wrote:
> 
> 
> On 1/25/24 09:26, Dmitry Baryshkov wrote:
>> On Thu, 25 Jan 2024 at 10:10, Umang Chheda <quic_uchheda@...cinc.com> wrote:
>>>
>>> Hi Dmitry,
>>>
>>> On 1/23/2024 5:48 PM, Dmitry Baryshkov wrote:
>>>> On Tue, 23 Jan 2024 at 12:28, Umang Chheda <quic_uchheda@...cinc.com> wrote:
>>>>>
>>>>> qcm6490-idp platform supports PM7250B PMIC as well.
>>>>> Add support for the same.
>>>>
>>>> The platform can not "support" PMIC. Please fix the commit message.
>>> Shall I change the commit message as below in the next patch ?
>>> "Add PM7250B PMIC support for qcm6490-idp"
>>
>> This is also not accurate. You are not adding support for the PMIC.
>> You are describing PMICs present on the board.
> 
> Umang, consider one of:
> 
> arm64: dts: qcom: qcm6490-idp:
> 
> "Include PM7250B"
> 
> "Enable PM7250B"
> 
> "Configure PM7250B"
> 
Ack, I have sent new version of my patch which addresses the feedback.

> Konrad

Thanks,
Umang