| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CALTww291wiYYMWuqUdDf1t7cKkHFs9gGQSRw+iPhUCsNv-Y6yg@mail.gmail.com>
Date: Thu, 25 Jan 2024 21:33:11 +0800
From: Xiao Ni <xni@...hat.com>
To: Yu Kuai <yukuai3@...wei.com>
Cc: agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com,
dm-devel@...ts.linux.dev, song@...nel.org, jbrassow@....redhat.com,
neilb@...e.de, heinzm@...hat.com, shli@...com, akpm@...l.org,
linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
yukuai1@...weicloud.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH v2 05/11] md: export helpers to stop sync_thread
Hi all
I build the kernel 6.7.0-rc8 with this patch set. The lvm2 regression
test result:
### failed: [ndev-vanilla] shell/integrity.sh
### failed: [ndev-vanilla] shell/lvchange-partial-raid10.sh
### failed: [ndev-vanilla] shell/lvchange-raid-transient-failures.sh
### failed: [ndev-vanilla] shell/lvchange-raid10.sh
### failed: [ndev-vanilla] shell/lvchange-rebuild-raid.sh
### failed: [ndev-vanilla] shell/lvconvert-cache-abort.sh
### failed: [ndev-vanilla] shell/lvconvert-raid-regionsize.sh
### failed: [ndev-vanilla]
shell/lvconvert-raid-reshape-linear_to_raid6-single-type.sh
### failed: [ndev-vanilla] shell/lvconvert-raid-reshape.sh
### failed: [ndev-vanilla] shell/lvconvert-raid-takeover-alloc-failure.sh
### failed: [ndev-vanilla] shell/lvconvert-raid-takeover-thin.sh
### failed: [ndev-vanilla] shell/lvconvert-raid-takeover.sh
### failed: [ndev-vanilla] shell/lvconvert-raid0-striped.sh
### failed: [ndev-vanilla] shell/lvconvert-raid0_to_raid10.sh
### failed: [ndev-vanilla] shell/lvconvert-raid10.sh
### failed: [ndev-vanilla] shell/lvconvert-raid5_to_raid10.sh
### failed: [ndev-vanilla] shell/lvconvert-repair-raid.sh
### failed: [ndev-vanilla] shell/lvconvert-striped-raid0.sh
### failed: [ndev-vanilla] shell/lvcreate-large-raid10.sh
### failed: [ndev-vanilla] shell/lvcreate-raid-nosync.sh
### failed: [ndev-vanilla] shell/lvcreate-raid10.sh
### failed: [ndev-vanilla] shell/lvdisplay-raid.sh
### failed: [ndev-vanilla] shell/lvextend-thin-raid.sh
### failed: [ndev-vanilla] shell/lvresize-fs-crypt.sh
### failed: [ndev-vanilla] shell/lvresize-raid.sh
### failed: [ndev-vanilla] shell/lvresize-raid10.sh
### failed: [ndev-vanilla] shell/pvck-dump.sh
### failed: [ndev-vanilla] shell/pvmove-raid-segtypes.sh
### failed: [ndev-vanilla] shell/select-report.sh
Regards
Xiao
On Wed, Jan 24, 2024 at 5:19 PM Yu Kuai <yukuai3@...wei.com> wrote:
>
> The new heleprs will be used in dm-raid in later patches to fix
> regressions and prevent calling md_reap_sync_thread() directly.
>
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
> drivers/md/md.c | 41 +++++++++++++++++++++++++++++++++++++----
> drivers/md/md.h | 3 +++
> 2 files changed, 40 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 6c5d0a372927..90cf31b53804 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -4915,30 +4915,63 @@ static void stop_sync_thread(struct mddev *mddev, bool locked, bool check_seq)
> mddev_lock_nointr(mddev);
> }
>
> -static void idle_sync_thread(struct mddev *mddev)
> +void md_idle_sync_thread(struct mddev *mddev)
> {
> + lockdep_assert_held(mddev->reconfig_mutex);
> +
> mutex_lock(&mddev->sync_mutex);
> clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
> + stop_sync_thread(mddev, true, true);
> + mutex_unlock(&mddev->sync_mutex);
> +}
> +EXPORT_SYMBOL_GPL(md_idle_sync_thread);
> +
> +void md_frozen_sync_thread(struct mddev *mddev)
> +{
> + lockdep_assert_held(mddev->reconfig_mutex);
> +
> + mutex_lock(&mddev->sync_mutex);
> + set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
> + stop_sync_thread(mddev, true, false);
> + mutex_unlock(&mddev->sync_mutex);
> +}
> +EXPORT_SYMBOL_GPL(md_frozen_sync_thread);
>
> +void md_unfrozen_sync_thread(struct mddev *mddev)
> +{
> + lockdep_assert_held(mddev->reconfig_mutex);
> +
> + mutex_lock(&mddev->sync_mutex);
> + clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
> + set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
> + md_wakeup_thread(mddev->thread);
> + sysfs_notify_dirent_safe(mddev->sysfs_action);
> + mutex_unlock(&mddev->sync_mutex);
> +}
> +EXPORT_SYMBOL_GPL(md_unfrozen_sync_thread);
> +
> +static void idle_sync_thread(struct mddev *mddev)
> +{
> if (mddev_lock(mddev)) {
> mutex_unlock(&mddev->sync_mutex);
> return;
> }
>
> + mutex_lock(&mddev->sync_mutex);
> + clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
> stop_sync_thread(mddev, false, true);
> mutex_unlock(&mddev->sync_mutex);
> }
>
> static void frozen_sync_thread(struct mddev *mddev)
> {
> - mutex_lock(&mddev->sync_mutex);
> - set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
> -
> if (mddev_lock(mddev)) {
> mutex_unlock(&mddev->sync_mutex);
> return;
> }
>
> + mutex_lock(&mddev->sync_mutex);
> + set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
> stop_sync_thread(mddev, false, false);
> mutex_unlock(&mddev->sync_mutex);
> }
> diff --git a/drivers/md/md.h b/drivers/md/md.h
> index 8d881cc59799..437ab70ce79b 100644
> --- a/drivers/md/md.h
> +++ b/drivers/md/md.h
> @@ -781,6 +781,9 @@ extern void md_rdev_clear(struct md_rdev *rdev);
> extern void md_handle_request(struct mddev *mddev, struct bio *bio);
> extern int mddev_suspend(struct mddev *mddev, bool interruptible);
> extern void mddev_resume(struct mddev *mddev);
> +extern void md_idle_sync_thread(struct mddev *mddev);
> +extern void md_frozen_sync_thread(struct mddev *mddev);
> +extern void md_unfrozen_sync_thread(struct mddev *mddev);
>
> extern void md_reload_sb(struct mddev *mddev, int raid_disk);
> extern void md_update_sb(struct mddev *mddev, int force);
> --
> 2.39.2
>
Powered by blists - more mailing lists