linux-kernel - Re: [PATCH 1/8] include/hrtimers: Move hrtimer base related definitions into hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmrxh6yw.ffs@tglx>
Date: Thu, 25 Jan 2024 14:34:47 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>, linux-kernel@...r.kernel.org
Cc: Frederic Weisbecker <frederic@...nel.org>, Ingo Molnar
 <mingo@...nel.org>, John Stultz <jstultz@...gle.com>, Stephen Boyd
 <sboyd@...nel.org>, Jonathan Corbet <corbet@....net>, Clemens Ladisch
 <clemens@...isch.de>, linux-doc@...r.kernel.org
Subject: Re: [PATCH 1/8] include/hrtimers: Move hrtimer base related
 definitions into hrtimer_defs

On Thu, Jan 25 2024 at 13:20, Anna-Maria Behnsen wrote:
> Thomas Gleixner <tglx@...utronix.de> writes:
>
>> On Tue, Jan 23 2024 at 17:46, Anna-Maria Behnsen wrote:
>>> hrtimer base related struct definitions are part of hrtimers.h as it is
>>> required there. With this, also the struct documentation which is for core
>>> code internal use, is exposed into the general api. To prevent this, all
>>> core internal definitions and the related includes are moved into
>>> hrtimer_defs header file.
>>
>> Shouldn't this simply move to kernel/time/... ? Nothing outside of it
>> needs hrtimer_base
>
> hrtimer_expires_remaining() which is defined in include/hrtimer.h
> dereferences hrtimer_clock_base; hrtimer_is_hres_active() also defined
> in include/hrtimer.h needs hrtimer_base.

Duh, yes.