linux-kernel - Re: [PATCH v4 1/3] leds: ktd2692: move ExpressWire code to library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240125134458.GK74950@google.com>
Date: Thu, 25 Jan 2024 13:44:58 +0000
From: Lee Jones <lee@...nel.org>
To: Duje Mihanović <duje.mihanovic@...le.hr>
Cc: Daniel Thompson <daniel.thompson@...aro.org>,
	Jingoo Han <jingoohan1@...il.com>, Pavel Machek <pavel@....cz>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Helge Deller <deller@....de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Karel Balej <balejk@...fyz.cz>,
	~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linux-leds@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v4 1/3] leds: ktd2692: move ExpressWire code to library

On Mon, 22 Jan 2024, Duje Mihanović wrote:

> The ExpressWire protocol is shared between at least KTD2692 and KTD2801
> with slight differences such as timings and the former not having a
> defined set of pulses for enabling the protocol (possibly because it
> does not support PWM unlike KTD2801). Despite these differences the
> ExpressWire handling code can be shared between the two, so move it into
> a library in preparation for adding KTD2801 support.
> 
> Suggested-by: Daniel Thompson <daniel.thompson@...aro.org>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
> ---
>  MAINTAINERS                       |   7 +++
>  drivers/leds/Kconfig              |   4 ++
>  drivers/leds/Makefile             |   3 +
>  drivers/leds/flash/Kconfig        |   2 +-
>  drivers/leds/flash/leds-ktd2692.c | 116 +++++++++-----------------------------

>  drivers/leds/leds-expresswire.c   |  68 ++++++++++++++++++++++
>  include/linux/leds-expresswire.h  |  36 ++++++++++++

Please can you separate the Expresswire addition into its own patch?

>  7 files changed, 146 insertions(+), 90 deletions(-)

-- 
Lee Jones [李琼斯]