linux-kernel - Re: [PATCH] hwmon: (pmbus/mp2975) Fix driver initialization for MP2975 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dea2217d-3d15-4b74-a6e2-ec64c3ff1ac0@roeck-us.net>
Date: Fri, 26 Jan 2024 10:38:37 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Konstantin Aladyshev <aladyshev22@...il.com>
Cc: Jean Delvare <jdelvare@...e.com>,
	Naresh Solanki <Naresh.Solanki@...ements.com>,
	Patrick Rudolph <patrick.rudolph@...ements.com>,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus/mp2975) Fix driver initialization for
 MP2975 device

On Fri, Jan 26, 2024 at 06:19:19PM +0300, Konstantin Aladyshev wrote:
> The commit 1feb31e810b0 ("hwmon: (pmbus/mp2975) Simplify VOUT code")
> has introduced a bug that makes it impossible to initialize MP2975
> device:
> """
> mp2975 5-0020: Failed to identify chip capabilities
> i2c i2c-5: new_device: Instantiated device mp2975 at 0x20
> i2c i2c-5: delete_device: Deleting device mp2975 at 0x20
> """
> Since the 'read_byte_data' function was removed from the
> 'pmbus_driver_info ' structure the driver no longer reports correctly
> that VOUT mode is direct. Therefore 'pmbus_identify_common' fails
> with error, making it impossible to initialize the device.
> 
> Restore 'read_byte_data' function to fix the issue.
> 
> Tested:
> - before: it is not possible to initialize MP2975 device with the
> 'mp2975' driver,
> - after: 'mp2975' correctly initializes MP2975 device and all sensor
> data is correct.
> 
> Fixes: 1feb31e810b0 ("hwmon: (pmbus/mp2975) Simplify VOUT code")
> 
> Signed-off-by: Konstantin Aladyshev <aladyshev22@...il.com>
> ---

When running checkpatch on your patch, I get:

total: 8 errors, 5 warnings, 0 checks, 29 lines checked

It looks like you used spaces instead of tabs for indentation.
Please run checkpatch on your patches before submitting.

Thanks,
Guenter