linux-kernel - Re: [PATCHv4 1/1] block: introduce content activity based ioprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbP/FRGfkBrtAm7y@x1-carbon>
Date: Fri, 26 Jan 2024 18:51:03 +0000
From: Niklas Cassel <Niklas.Cassel@....com>
To: zhaoyang.huang <zhaoyang.huang@...soc.com>
CC: Andrew Morton <akpm@...ux-foundation.org>, Jens Axboe <axboe@...nel.dk>,
	Matthew Wilcox <willy@...radead.org>, Yu Zhao <yuzhao@...gle.com>, Damien Le
 Moal <dlemoal@...nel.org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>, Hannes Reinecke <hare@...e.de>, Linus Walleij
	<linus.walleij@...aro.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Zhaoyang Huang
	<huangzhaoyang@...il.com>, "steve.kang@...soc.com" <steve.kang@...soc.com>
Subject: Re: [PATCHv4 1/1] block: introduce content activity based ioprio

On Fri, Jan 26, 2024 at 08:08:00PM +0800, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@...soc.com>

(snip)

> --- a/include/uapi/linux/ioprio.h
> +++ b/include/uapi/linux/ioprio.h
> @@ -71,12 +71,24 @@ enum {
>   * class and level.
>   */
>  #define IOPRIO_HINT_SHIFT		IOPRIO_LEVEL_NR_BITS
> +#ifdef CONFIG_CONTENT_ACT_BASED_IOPRIO
> +#define IOPRIO_HINT_NR_BITS		3
> +#else
>  #define IOPRIO_HINT_NR_BITS		10
> +#endif

Remember, this is a uapi header.
The ABI cannot be one way if a certain Kconfig is set,
but another way if that same Kconfig is not set.

What could go wrong? :)


Kind regards,
Niklas