linux-kernel - Re: [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: Time Based Scheduling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240126121928.48a44327@kernel.org>
Date: Fri, 26 Jan 2024 12:19:28 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: rohan.g.thomas@...el.com
Cc: esben@...nix.com, alexandre.torgue@...s.st.com, conor+dt@...nel.org,
 davem@...emloft.net, devicetree@...r.kernel.org, edumazet@...gle.com,
 fancer.lancer@...il.com, joabreu@...opsys.com,
 krzysztof.kozlowski+dt@...aro.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
 mcoquelin.stm32@...il.com, netdev@...r.kernel.org, pabeni@...hat.com,
 peppe.cavallaro@...com, robh@...nel.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: Time Based
 Scheduling

On Sat, 27 Jan 2024 01:36:34 +0800 rohan.g.thomas@...el.com wrote:
> > The tricky part here is that the whole devicetree bindings story for the
> > stmmac driver is filled with such configuration choices. As such, it is
> > only natural to add the property you are suggesting here. I completely
> > agree. But you can also argue that it is "wrong", because it does not
> > just describe the hardware, but also a configuration choice.  
> 
> Isn't this requirement of using enhanced tx desc instead of normal tx
> desc to support TBS is specific to Synopsys IP? Switching from
> normal desc to enhanced desc at the time of tc-etf qdisc offload
> cannot be done without traffic disruption, which I don't think is
> acceptable. Since this behavior is IP specific, can we consider
> this as an OS configuration choice?

Why is traffic disruption not acceptable when TBS gets turned on?
User has to install the right qdisc to enable TBS, I presume,
installing qdiscs destroys the old ones which also leads to packet
drops.