linux-kernel - Re: [PATCH v2] powerpc/cell: Code cleanup for spufs_mfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <fbae8c8e-6788-4749-b7e0-b64c9fffe85a@app.fastmail.com>
Date: Fri, 26 Jan 2024 07:27:23 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Kunwu Chan" <chentao@...inos.cn>, "Jeremy Kerr" <jk@...abs.org>,
 "Michael Ellerman" <mpe@...erman.id.au>,
 "Nicholas Piggin" <npiggin@...il.com>,
 "Christophe Leroy" <christophe.leroy@...roup.eu>, aneesh.kumar@...nel.org,
 "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] powerpc/cell: Code cleanup for spufs_mfc_flush

On Fri, Jan 26, 2024, at 03:12, Kunwu Chan wrote:
> This part was commented from commit a33a7d7309d7
> ("[PATCH] spufs: implement mfc access for PPE-side DMA")
> in about 18 years before.
>
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> Suggested-by: Christophe Leroy <christophe.leroy@...roup.eu>

Nobody is actively working on this code, so it clearly won't
be needed in the future.

Acked-by: Arnd Bergmann <arnd@...db.de>

On the other hand there is probably little use in removing
the dead code either. It looks you sent a lot of these
patches with identical changelog texts to remove blocks
of dead code, which does not seem productive to me as
these were clearly all left in the code to document
something.

      Arnd