linux-kernel - Re: [PATCH v4 05/11] arm64: dts: qcom: x1e80100: Add TCSR node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbNq4b813348ZiV8@linaro.org>
Date: Fri, 26 Jan 2024 10:18:41 +0200
From: Abel Vesa <abel.vesa@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sibi Sankar <quic_sibis@...cinc.com>,
	Rajendra Nayak <quic_rjendra@...cinc.com>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 05/11] arm64: dts: qcom: x1e80100: Add TCSR node

On 24-01-23 19:09:37, Konrad Dybcio wrote:
> 
> 
> On 1/23/24 12:01, Abel Vesa wrote:
> > Add the TCSR clock controller and halt register space node.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> > ---
> 
> The former - yes, the latter - ?

Hm, so halt register space is at 0x1f60000. That would be in the mutex
region. But the mutex region is 0x20000 short, even on SM8650 and
SM8550. Need to see why is that, historically.

Either way, the tcsr node region still contains the regs needed by the
SCM driver to enable download mode. So I will rephrase this accordingly.

> 
> Konrad
> >   arch/arm64/boot/dts/qcom/x1e80100.dtsi | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > index be69e71b7f53..2b6c55a486b2 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > @@ -2606,6 +2606,14 @@ tcsr_mutex: hwlock@...0000 {
> >   			#hwlock-cells = <1>;
> >   		};
> > +		tcsr: clock-controller@...0000 {
> > +			compatible = "qcom,x1e80100-tcsr", "syscon";
> > +			reg = <0 0x01fc0000 0 0x30000>;
> > +			clocks = <&rpmhcc RPMH_CXO_CLK>;
> > +			#clock-cells = <1>;
> > +			#reset-cells = <1>;
> > +		};
> > +
> >   		gem_noc: interconnect@...00000 {
> >   			compatible = "qcom,x1e80100-gem-noc";
> >   			reg = <0 0x26400000 0 0x311200>;
> >