linux-kernel - Re: [PATCH 3/4] crypto: hisilicon/sec2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <273d30b3-edba-4f4c-8138-fe83dbfd83aa@huawei.com>
Date: Fri, 26 Jan 2024 16:40:39 +0800
From: taoqi <taoqi10@...wei.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: <davem@...emloft.net>, <liulongfang@...wei.com>,
	<linux-kernel@...r.kernel.org>, <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH 3/4] crypto: hisilicon/sec2 - fix some cleanup issues

On 2024/1/25 17:37, Herbert Xu wrote:
> On Fri, Dec 29, 2023 at 02:44:20PM +0800, Qi Tao wrote:
>>
>> @@ -1371,7 +1371,7 @@ static int sec_skcipher_bd_fill_v3(struct sec_ctx *ctx, struct sec_req *req)
>>   	sec_sqe3->bd_param = cpu_to_le32(bd_param);
>>   
>>   	sec_sqe3->c_len_ivin |= cpu_to_le32(c_req->c_len);
>> -	sec_sqe3->tag = cpu_to_le64(req);
>> +	sec_sqe3->tag = cpu_to_le64((unsigned long)(uintptr_t)req);
> 
> Please explain why you're casting twice.
> 
> Thanks,

I'm sorry. I made a mistake here. unsigned long and uintptr_t are the 
same data type in linux kernel. The type cast is invalidly repeated 
here. Can I just keep (unsigned long) one cast?