linux-kernel - Re: [PATCH][next] crypto: pcbc: remove redundant assignment to nbytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZbN1WYSIKqJl6Zu9@gondor.apana.org.au>
Date: Fri, 26 Jan 2024 17:03:21 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Colin Ian King <colin.i.king@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] crypto: pcbc: remove redundant assignment to nbytes

On Tue, Jan 16, 2024 at 10:43:02AM +0000, Colin Ian King wrote:
> The assignment to nbytes is redundant, the while loop needs
> to just refer to the value in walk.nbytes and the value of
> nbytes is being re-assigned inside the loop on both paths
> of the following if-statement.  Remove redundant assignment.
> 
> Cleans up clang scan build warning:
> warning: Although the value stored to 'nbytes' is used in
> the enclosing expression, the value is never actually read
> from 'nbytes' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  crypto/pcbc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt