linux-kernel - Re: [PATCH v13A 26/35] x86/fred: FRED entry/exit and dispatch code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 26 Jan 2024 11:05:19 +0100
From: Borislav Petkov <bp@...en8.de>
To: Xin Li <xin3.li@...el.com>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org, linux-hyperv@...r.kernel.org,
	kvm@...r.kernel.org, xen-devel@...ts.xenproject.org,
	tglx@...utronix.de, mingo@...hat.com, dave.hansen@...ux.intel.com,
	x86@...nel.org, hpa@...or.com, luto@...nel.org, pbonzini@...hat.com,
	seanjc@...gle.com, peterz@...radead.org, jgross@...e.com,
	ravi.v.shankar@...el.com, mhiramat@...nel.org,
	andrew.cooper3@...rix.com, jiangshanlai@...il.com,
	nik.borisov@...e.com, shan.kang@...el.com
Subject: Re: [PATCH v13A 26/35] x86/fred: FRED entry/exit and dispatch code

On Sat, Dec 09, 2023 at 01:42:14PM -0800, Xin Li wrote:
> +static noinstr void fred_intx(struct pt_regs *regs)
> +{
> +	switch (regs->fred_ss.vector) {
> +	/* Opcode 0xcd, 0x3, NOT INT3 (opcode 0xcc) */
> +	case X86_TRAP_BP:
> +		return exc_int3(regs);
> +
> +	/* Opcode 0xcd, 0x4, NOT INTO (opcode 0xce) */
> +	case X86_TRAP_OF:
> +		return exc_overflow(regs);
> +
> +	/* INT80 */
> +	case IA32_SYSCALL_VECTOR:
> +		if (ia32_enabled())
> +			return int80_emulation(regs);

Second compiler no likey:

arch/x86/entry/entry_fred.c:68:11: error: implicit declaration of function 'int80_emulation' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                        return int80_emulation(regs);
                               ^
arch/x86/entry/entry_fred.c:68:4: error: void function 'fred_intx' should not return a value [-Wreturn-type]
                        return int80_emulation(regs);
                        ^      ~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

config is attached.

compiler is Ubuntu clang version 14.0.0-1ubuntu1.1.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

View attachment "00-38-19-randconfig-x86_64-14904.cfg" of type "text/plain" (170738 bytes)