[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZbOQY3cs5emASvzs@sunspire>
Date: Fri, 26 Jan 2024 12:58:43 +0200
From: Petre Rodan <petre.rodan@...dimension.ro>
To: marius.cristea@...rochip.com
Cc: jic23@...nel.org, lars@...afoo.de, robh+dt@...nel.org,
jdelvare@...e.com, linux@...ck-us.net, linux-hwmon@...r.kernel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] iio: adc: adding support for PAC193x
Hello Marius,
a quick static scan reported the following
On Mon, Jan 22, 2024 at 10:47:12AM +0200, marius.cristea@...rochip.com wrote:
> From: Marius Cristea <marius.cristea@...rochip.com>
>
> This is the iio driver for Microchip
> PAC193X series of Power Monitor with Accumulator chip family.
[..]
> + mutex_init(&info->lock);
> + ret = devm_add_action_or_reset(&client->dev, pac1934_mutex_destroy,
> + &info->lock);
> +
> + /*
> + * do now any chip specific initialization (e.g. read/write
> + * some registers), enable/disable certain channels, change the sampling
> + * rate to the requested value
> + */
> + ret = pac1934_chip_configure(info);
> + if (ret < 0)
> + return ret;
the previous assignation of ret is never used, so either dead code or you might
have wanted to return early based on it's value.
cheers,
peter
--
petre rodan
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists