linux-kernel - Re: [PATCH v3] erofs: relaxed temporary buffers allocation on readahead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b5387e8-3251-4750-844e-5c34b36eee87@linux.alibaba.com>
Date: Fri, 26 Jan 2024 21:30:25 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Yue Hu <zbestahu@...il.com>
Cc: linux-erofs@...ts.ozlabs.org, LKML <linux-kernel@...r.kernel.org>,
 Yue Hu <huyue2@...lpad.com>, Chunhai Guo <guochunhai@...o.com>
Subject: Re: [PATCH v3] erofs: relaxed temporary buffers allocation on
 readahead

Hi Yue,

On 2024/1/26 18:46, Yue Hu wrote:
> On Fri, 26 Jan 2024 13:36:16 +0800
> Gao Xiang <hsiangkao@...ux.alibaba.com> wrote:
> 

..

>>   	/*
>> @@ -1276,7 +1280,11 @@ static int z_erofs_decompress_pcluster(struct z_erofs_decompress_backend *be,
>>   					.inplace_io = overlapped,
>>   					.partial_decoding = pcl->partial,
>>   					.fillgaps = pcl->multibases,
>> +					.gfp = pcl->besteffort ?
>> +						GFP_KERNEL | __GFP_NOFAIL :
>> +						GFP_NOWAIT | __GFP_NORETRY
>>   				 }, be->pagepool);
>> +	pcl->besteffort = false;
> 
> reposition it following `pcl->multibases = false`?

Good idea! Let me update this.

Thanks,
Gao Xiang