linux-kernel - Re: [PATCH v7 09/15] x86/sgx: Charge mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.2h5w1w0awjvjmi@hhuan26-mobl.amr.corp.intel.com>
Date: Fri, 26 Jan 2024 10:21:22 -0600
From: "Haitao Huang" <haitao.huang@...ux.intel.com>
To: "hpa@...or.com" <hpa@...or.com>, "linux-sgx@...r.kernel.org"
 <linux-sgx@...r.kernel.org>, "x86@...nel.org" <x86@...nel.org>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
 "jarkko@...nel.org" <jarkko@...nel.org>, "cgroups@...r.kernel.org"
 <cgroups@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "mkoutny@...e.com" <mkoutny@...e.com>,
 "tglx@...utronix.de" <tglx@...utronix.de>, "Mehta, Sohil"
 <sohil.mehta@...el.com>, "tj@...nel.org" <tj@...nel.org>, "mingo@...hat.com"
 <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>, "Huang, Kai"
 <kai.huang@...el.com>
Cc: "kristen@...ux.intel.com" <kristen@...ux.intel.com>,
 "yangjie@...rosoft.com" <yangjie@...rosoft.com>, "Li, Zhiquan1"
 <zhiquan1.li@...el.com>, "seanjc@...gle.com" <seanjc@...gle.com>,
 "mikko.ylinen@...ux.intel.com" <mikko.ylinen@...ux.intel.com>, "Zhang, Bo"
 <zhanb@...rosoft.com>, "anakrish@...rosoft.com" <anakrish@...rosoft.com>
Subject: Re: [PATCH v7 09/15] x86/sgx: Charge mem_cgroup for per-cgroup
 reclamation

On Fri, 26 Jan 2024 08:37:25 -0600, Huang, Kai <kai.huang@...el.com> wrote:

>
>>
>> Signed-off-by: Haitao Huang <haitao.huang@...ux.intel.com>
>> Reported-by: Mikko Ylinen <mikko.ylinen@...ux.intel.com>
>> ---
>
> Non-technical staff:
>
> I believe checkpatch requires you to have a "Closes" tag after  
> "Reported-by"
> otherwise it complains something like this:
>
>   WARNING: Reported-by: should be immediately followed by Closes: with a  
> URL
>   to the report
>
> Not sure how strict this rule is, but seems you forgot to run checkpatch  
> so just
> a reminder.

Yeah I did remember run checkpatch this time and last time :-)
Here is what I see from documentation[1]:"The tag should be followed by a  
Closes: tag pointing to the report, unless the report is not available on  
the web". So it seems to allow exceptions.
Mikko mentioned this issue to me in private IM so this is not available on  
web.

Thanks
Haitao

https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes