linux-kernel - Re: [PATCH 05/11] arm64: Kconfig: Clean up tautological LLVM version checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbPlFGHjJg9X_pHt@FVFF77S0Q05N>
Date: Fri, 26 Jan 2024 17:00:15 +0000
From: Mark Rutland <mark.rutland@....com>
To: Nathan Chancellor <nathan@...nel.org>
Cc: akpm@...ux-foundation.org, masahiroy@...nel.org, nicolas@...sle.eu,
	linux-kbuild@...r.kernel.org, llvm@...ts.linux.dev,
	patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
	catalin.marinas@....com, will@...nel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 05/11] arm64: Kconfig: Clean up tautological LLVM version
 checks

On Fri, Jan 26, 2024 at 09:10:25AM -0700, Nathan Chancellor wrote:
> On Fri, Jan 26, 2024 at 12:59:55PM +0000, Mark Rutland wrote:
> > On Thu, Jan 25, 2024 at 03:55:11PM -0700, Nathan Chancellor wrote:
> > >  config CPU_BIG_ENDIAN
> > >  	bool "Build big-endian kernel"
> > > -	depends on !LD_IS_LLD || LLD_VERSION >= 130000
> > >  	# https://github.com/llvm/llvm-project/commit/1379b150991f70a5782e9a143c2ba5308da1161c
> > 
> > We can delete the URL here, since that was just to describe why this depended
> > upon LLVM 13+; it's weird for it to sit here on its own.
> 
> I think this is the URL for the fix for the problem brought up by
> commit 146a15b87335 ("arm64: Restrict CPU_BIG_ENDIAN to GNU as or LLVM
> IAS 15.x or newer"), so I think it should stay? It does not look like I
> ever added a link or context for the LLD line, I definitely should have.

Whoops; I clearly misread that, and yes it should stay.

Sorry about that; for the patch as-is:

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.