linux-kernel - Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87il3ggfz9.ffs@tglx>
Date: Fri, 26 Jan 2024 18:30:02 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Byungchul Park <byungchul@...com>, linux-kernel@...r.kernel.org
Cc: kernel_team@...ynix.com, torvalds@...ux-foundation.org,
 damien.lemoal@...nsource.wdc.com, linux-ide@...r.kernel.org,
 adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, mingo@...hat.com,
 peterz@...radead.org, will@...nel.org, rostedt@...dmis.org,
 joel@...lfernandes.org, sashal@...nel.org, daniel.vetter@...ll.ch,
 duyuyang@...il.com, johannes.berg@...el.com, tj@...nel.org, tytso@....edu,
 willy@...radead.org, david@...morbit.com, amir73il@...il.com,
 gregkh@...uxfoundation.org, kernel-team@....com, linux-mm@...ck.org,
 akpm@...ux-foundation.org, mhocko@...nel.org, minchan@...nel.org,
 hannes@...xchg.org, vdavydov.dev@...il.com, sj@...nel.org,
 jglisse@...hat.com, dennis@...nel.org, cl@...ux.com, penberg@...nel.org,
 rientjes@...gle.com, vbabka@...e.cz, ngupta@...are.org,
 linux-block@...r.kernel.org, josef@...icpanda.com,
 linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk, jack@...e.cz,
 jlayton@...nel.org, dan.j.williams@...el.com, hch@...radead.org,
 djwong@...nel.org, dri-devel@...ts.freedesktop.org,
 rodrigosiqueiramelo@...il.com, melissa.srw@...il.com,
 hamohammed.sa@...il.com, 42.hyeyoo@...il.com, chris.p.wilson@...el.com,
 gwan-gyeong.mun@...el.com, max.byungchul.park@...il.com,
 boqun.feng@...il.com, longman@...hat.com, hdanton@...a.com,
 her0gyugyu@...il.com
Subject: Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker
 annotation in AP thread

On Wed, Jan 24 2024 at 20:59, Byungchul Park wrote:

Why is lockdep in the subsystem prefix here? You are changing the CPU
hotplug (not hotplus) code, right?

> cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was
> introduced to make lockdep_assert_cpus_held() work in AP thread.
>
> However, the annotation is too strong for that purpose. We don't have to
> use more than try lock annotation for that.

This lacks a proper explanation why this is too strong.

> Furthermore, now that Dept was introduced, false positive alarms was
> reported by that. Replaced it with try lock annotation.

I still have zero idea what this is about.

Thanks,

        tglx