linux-kernel - [PATCH] net/tipc: Remove Documentation Warnings for `Excess struct member`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Sat, 27 Jan 2024 03:21:09 +0000
From: Carlos Ortiz <jmp0x29A@...tonmail.com>
To: tipc-discussion@...ts.sourceforge.net
Cc: skhan@...uxfoundation.org, Carlos Ortiz <jmp0x29A@...tonmail.com>, Jon Maloy <jmaloy@...hat.com>, Ying Xue <ying.xue@...driver.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] net/tipc: Remove Documentation Warnings for `Excess struct member`

As far as I can tell,the struct `inputq` and `namedq` were never part of the `tipc_node`,
therefor removing the documentation comments this will make the warnings for ./net/tipc/node.c when
running `make htmldocs` to be gone.

For socket.c, and documentation comment was added on commit 365ad353c2564bba8835290061308ba825166b3a
but the struct member was not added in addition of removing `blocking_link` also move `dupl_rcvcnt`
documentations a few lines up to match the struct member order.

Signed-off-by: Carlos Ortiz <jmp0x29A@...tonmail.com>
---
 net/tipc/node.c   | 2 --
 net/tipc/socket.c | 3 +--
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index 3105abe97bb9..c1e890a82434 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -86,8 +86,6 @@ struct tipc_bclink_entry {
  * @lock: rwlock governing access to structure
  * @net: the applicable net namespace
  * @hash: links to adjacent nodes in unsorted hash chain
- *
 @inputq: pointer to input queue containing messages for msg event
- * @namedq: pointer to name table input queue with name table messages
  * @active_links: bearer ids of active links, used as index into links[] array
  * @links: array containing references to all links to node
  * @bc_entry: broadcast link entry
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index bb1118d02f95..a022719882ce 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -80,11 +80,10 @@ struct sockaddr_pair {
  * @phdr: preformatted message header used when sending messages
  * @cong_links: list of congested links
  * @publications: list of publications for port
- * @blocking_link: address of the congested link we are currently sleeping on
  * @pub_count: total # of publications port has made during its lifetime
+ * @dupl_rcvcnt: number of bytes counted twice, in both backlog and rcv queue
  * @conn_timeout: the time we can wait for an unresponded setup request
  * @probe_unacked: prob
e has not received ack yet
- * @dupl_rcvcnt: number of bytes counted twice, in both backlog and rcv queue
  * @cong_link_cnt: number of congested links
  * @snt_unacked: # messages sent by socket, and not yet acked by peer
  * @snd_win: send window size
-- 
2.43.0

Download attachment "signature.asc" of type "application/pgp-signature" (250 bytes)