linux-kernel - Re: [PATCH v2] iio: humidity: hdc3020: fix temperature offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240127144055.2e46c77d@jic23-huawei>
Date: Sat, 27 Jan 2024 14:40:55 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Dimitri Fedrau <dima.fedrau@...il.com>
Cc: Nuno Sa <nuno.sa@...log.com>, Javier Carrasco
 <javier.carrasco.cruz@...il.com>, Li peiyu <579lpy@...il.com>, Lars-Peter
 Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: humidity: hdc3020: fix temperature offset

On Fri, 26 Jan 2024 14:52:26 +0100
Dimitri Fedrau <dima.fedrau@...il.com> wrote:

> The temperature offset should be negative according to the datasheet.
> Adding a minus to the existing offset results in correct temperature
> calculations.
> 
> Fixes: <c9180b8e39be> ("iio: humidity: Add driver for ti HDC302x humidity sensors")

<> are not part of the fixes tag syntax.  I guess you saw the
one case of that which was in my tree earlier in the week and
I've now fixed up?

I've fixed it up here as well.

Applied to the fixes-togreg branch of iio.git.

Jonathan

> Reviewed-by: Nuno Sa <nuno.sa@...log.com>
> Signed-off-by: Dimitri Fedrau <dima.fedrau@...il.com>
> ---
> Changes in V2:
> - Added Fixes: tag
> 
>  drivers/iio/humidity/hdc3020.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c
> index 4e3311170725..ed70415512f6 100644
> --- a/drivers/iio/humidity/hdc3020.c
> +++ b/drivers/iio/humidity/hdc3020.c
> @@ -322,7 +322,7 @@ static int hdc3020_read_raw(struct iio_dev *indio_dev,
>  		if (chan->type != IIO_TEMP)
>  			return -EINVAL;
>  
> -		*val = 16852;
> +		*val = -16852;
>  		return IIO_VAL_INT;
>  
>  	default: