linux-kernel - Re: [PATCH v3] hwmon: (pmbus/mp2975) Fix driver initialization for MP2975 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c853502f-230b-47b3-9c93-28d99f4d83b8@roeck-us.net>
Date: Sat, 27 Jan 2024 07:24:05 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Patrick Rudolph <patrick.rudolph@...ements.com>,
 Konstantin Aladyshev <aladyshev22@...il.com>
Cc: Jean Delvare <jdelvare@...e.com>,
 Naresh Solanki <Naresh.Solanki@...ements.com>, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] hwmon: (pmbus/mp2975) Fix driver initialization for
 MP2975 device

On 1/27/24 00:56, Patrick Rudolph wrote:
> Hi Konstantin,
> Thank you for fixing this regression.
> 
> The comment is no longer true as the driver doesn't internally convert
> from VID to direct,
> but rather configures READ_VOUT using MFR_DC_LOOP_CTRL.
> 
> The comment thus should read as the following:
> 
> Report direct format as configured by MFR_DC_LOOP_CTRL.
> Unlike on MP2971/MP2973 the reported VOUT_MODE isn't automatically
> internally updated,
> but always reads as PB_VOUT_MODE_VID.
> 
> Regards,
> Patrick

Please don't top-post.

This patch has already been applied. Please send a follow-up to that patch
to update it.

Thanks,
Guenter