linux-kernel - Re: [PATCH 1/4] iio: health: afe4403: Use devm action helper for regulator disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240127154836.153127a3@jic23-huawei>
Date: Sat, 27 Jan 2024 15:48:36 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andrew Davis <afd@...com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] iio: health: afe4403: Use devm action helper for
 regulator disable

On Tue, 23 Jan 2024 08:09:15 -0600
Andrew Davis <afd@...com> wrote:

> Use a device lifecycle managed action for regulator disable function.
> This helps prevent mistakes like unregistering out of order in cleanup
> functions and forgetting to unregister on error paths.
> 
> Signed-off-by: Andrew Davis <afd@...com>
Hi Andrew,

All applied.

You could make use of dev_err_probe() as well to save a few lines if
you want to (as a follow up patch).

Thanks,

Jonathan