linux-kernel - Re: [PATCH net-next v3 0/3] Per epoll context busy poll support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65b52d6381de7_3a9e0b2943d@willemb.c.googlers.com.notmuch>
Date: Sat, 27 Jan 2024 11:20:51 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Joe Damato <jdamato@...tly.com>, 
 linux-kernel@...r.kernel.org, 
 netdev@...r.kernel.org
Cc: chuck.lever@...cle.com, 
 jlayton@...nel.org, 
 linux-api@...r.kernel.org, 
 brauner@...nel.org, 
 edumazet@...gle.com, 
 davem@...emloft.net, 
 alexander.duyck@...il.com, 
 sridhar.samudrala@...el.com, 
 kuba@...nel.org, 
 willemdebruijn.kernel@...il.com, 
 weiwan@...gle.com, 
 Joe Damato <jdamato@...tly.com>, 
 Alexander Viro <viro@...iv.linux.org.uk>, 
 Andrew Waterman <waterman@...s.berkeley.edu>, 
 Arnd Bergmann <arnd@...db.de>, 
 Dominik Brodowski <linux@...inikbrodowski.net>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Jan Kara <jack@...e.cz>, 
 Jiri Slaby <jirislaby@...nel.org>, 
 Jonathan Corbet <corbet@....net>, 
 Julien Panis <jpanis@...libre.com>, 
 linux-doc@...r.kernel.org (open list:DOCUMENTATION), 
 "(open list:FILESYSTEMS \\(VFS and infrastructure\\))" <linux-fsdevel@...r.kernel.org>, 
 Michael Ellerman <mpe@...erman.id.au>, 
 Nathan Lynch <nathanl@...ux.ibm.com> (open list:FILESYSTEMS \(VFS and infrastructure\)), 
 Palmer Dabbelt <palmer@...belt.com>, 
 Steve French <stfrench@...rosoft.com>, 
 Thomas Huth <thuth@...hat.com>, 
 Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH net-next v3 0/3] Per epoll context busy poll support

Joe Damato wrote:
> Greetings:
> 
> Welcome to v3. Cover letter updated from v2 to explain why ioctl and
> adjusted my cc_cmd to try to get the correct people in addition to folks
> who were added in v1 & v2. Labeled as net-next because it seems networking
> related to me even though it is fs code.
> 
> TL;DR This builds on commit bf3b9f6372c4 ("epoll: Add busy poll support to
> epoll with socket fds.") by allowing user applications to enable
> epoll-based busy polling and set a busy poll packet budget on a per epoll
> context basis.
> 
> This makes epoll-based busy polling much more usable for user
> applications than the current system-wide sysctl and hardcoded budget.
> 
> To allow for this, two ioctls have been added for epoll contexts for
> getting and setting a new struct, struct epoll_params.
> 
> ioctl was chosen vs a new syscall after reviewing a suggestion by Willem
> de Bruijn [1]. I am open to using a new syscall instead of an ioctl, but it
> seemed that: 
>   - Busy poll affects all existing epoll_wait and epoll_pwait variants in
>     the same way, so new verions of many syscalls might be needed. It

There is no need to support a new feature on legacy calls. Applications have
to be upgraded to the new ioctl, so they can also be upgraded to the latest
epoll_wait variant.

epoll_pwait extends epoll_wait with a sigmask.
epoll_pwait2 extends extends epoll_pwait with nsec resolution timespec.
Since they are supersets, nothing is lots by limiting to the most recent API.

In the discussion of epoll_pwait2 the addition of a forward looking flags
argument was discussed, but eventually dropped. Based on the argument that
adding a syscall is not a big task and does not warrant preemptive code.
This decision did receive a suitably snarky comment from Jonathan Corbet [1].

It is definitely more boilerplate, but essentially it is as feasible to add an
epoll_pwait3 that takes an optional busy poll argument. In which case, I also
believe that it makes more sense to configure the behavior of the syscall
directly, than through another syscall and state stored in the kernel.

I don't think that the usec fine grain busy poll argument is all that useful.
Documentation always suggests setting it to 50us or 100us, based on limited
data. Main point is to set it to exceed the round-trip delay of whatever the
process is trying to wait on. Overestimating is not costly, as the call
returns as soon as the condition is met. An epoll_pwait3 flag EPOLL_BUSY_POLL
with default 100us might be sufficient.

[1] https://lwn.net/Articles/837816/

>     seems much simpler for users to use the correct
>     epoll_wait/epoll_pwait for their app and add a call to ioctl to enable
>     or disable busy poll as needed. This also probably means less work to
>     get an existing epoll app using busy poll.