linux-kernel - Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <r6u3m7ux2v7w3bg24dqmrolos4jna74nfeheudgxmxcn3iuets@qkuaj2son5mr>
Date: Sat, 27 Jan 2024 20:15:59 +0200
From: "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>
To: "Huang, Kai" <kai.huang@...el.com>
Cc: "tglx@...utronix.de" <tglx@...utronix.de>, 
	"mingo@...hat.com" <mingo@...hat.com>, "x86@...nel.org" <x86@...nel.org>, "bp@...en8.de" <bp@...en8.de>, 
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>, 
	"Reshetova, Elena" <elena.reshetova@...el.com>, "Nakajima, Jun" <jun.nakajima@...el.com>, 
	"rafael@...nel.org" <rafael@...nel.org>, "peterz@...radead.org" <peterz@...radead.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"sathyanarayanan.kuppuswamy@...ux.intel.com" <sathyanarayanan.kuppuswamy@...ux.intel.com>, "Hunter, Adrian" <adrian.hunter@...el.com>, 
	"thomas.lendacky@....com" <thomas.lendacky@....com>, "ashish.kalra@....com" <ashish.kalra@....com>, 
	"kexec@...ts.infradead.org" <kexec@...ts.infradead.org>, "seanjc@...gle.com" <seanjc@...gle.com>, 
	"bhe@...hat.com" <bhe@...hat.com>, "linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>
Subject: Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI
 MADT wakeup method

On Fri, Jan 26, 2024 at 02:21:30PM +0000, Huang, Kai wrote:
> > +static int __init acpi_mp_setup_reset(u64 reset_vector)
> > +{
> > +	pgd_t *pgd;
> > +	struct x86_mapping_info info = {
> > +		.alloc_pgt_page = alloc_pgt_page,
> > +		.free_pgt_page	= free_pgt_page,
> > +		.page_flag      = __PAGE_KERNEL_LARGE_EXEC,
> > +		.kernpg_flag    = _KERNPG_TABLE_NOENC,
> > +	};
> 
> Nit: Reverse Christmas-tree style
> 
> [...]

Okay, will fix if new version is required.

> >  
> > -#define ACPI_MP_WAKE_COMMAND_WAKEUP    1
> > +#define ACPI_MP_WAKE_COMMAND_WAKEUP	1
> 
> Nit: Is this change intended?

Yes. Changed to indentation with tabs.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov