linux-kernel - Re: [PATCH] powerpc/papr_scm: Move duplicate definitions to common header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bb645372-b40a-4326-91e9-ac8cdad0dd29@linux.ibm.com>
Date: Sun, 28 Jan 2024 00:31:11 +0530
From: Shivaprasad G Bhat <sbhat@...ux.ibm.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
        "nvdimm@...ts.linux.dev" <nvdimm@...ts.linux.dev>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "aneesh.kumar@...ux.ibm.com" <aneesh.kumar@...ux.ibm.com>,
        "ira.weiny@...el.com" <ira.weiny@...el.com>,
        "vaibhav@...ux.ibm.com" <vaibhav@...ux.ibm.com>
Subject: Re: [PATCH] powerpc/papr_scm: Move duplicate definitions to common
 header files

On 1/26/24 02:46, Christophe Leroy wrote:
>
> Le 18/04/2022 à 06:38, Shivaprasad G Bhat a écrit :
>> papr_scm and ndtest share common PDSM payload structs like
>> nd_papr_pdsm_health. Presently these structs are duplicated across
>> papr_pdsm.h and ndtest.h header files. Since 'ndtest' is essentially
>> arch independent and can run on platforms other than PPC64, a way
>> needs to be deviced to avoid redundancy and duplication of PDSM
>> structs in future.
>>
>> So the patch proposes moving the PDSM header from arch/powerpc/include-
>> -/uapi/ to the generic include/uapi/linux directory. Also, there are
>> some #defines common between papr_scm and ndtest which are not exported
>> to the user space. So, move them to a header file which can be shared
>> across ndtest and papr_scm via newly introduced include/linux/papr_scm.h.
>>
>> Signed-off-by: Shivaprasad G Bhat <sbhat@...ux.ibm.com>
>> Signed-off-by: Vaibhav Jain <vaibhav@...ux.ibm.com>
>> Suggested-by: "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>
> This patch doesn't apply, if still relevant can you please rebase and
> re-submit ?

Thanks for taking a look.


I have rebased and reposted the patch here

https://lore.kernel.org/nvdimm/170638176942.112443.2937254675538057083.stgit@ltcd48-lp2.aus.stglab.ibm.com/T/#u


Thanks!

Shivaprasad

<snip>