linux-kernel - Re: [PATCH] perf evsel: Fix duplicate initialization of data->id in evsel__parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbVZRrPp9YusOHzB@kernel.org>
Date: Sat, 27 Jan 2024 16:28:06 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Yang Jihong <yangjihong1@...wei.com>
Cc: peterz@...radead.org, mingo@...hat.com, namhyung@...nel.org,
	mark.rutland@....com, alexander.shishkin@...ux.intel.com,
	jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf evsel: Fix duplicate initialization of data->id in
 evsel__parse_sample()

Em Sat, Jan 27, 2024 at 02:57:56AM +0000, Yang Jihong escreveu:
> data->id has been initialized at line 2362, remove duplicate initialization.
> 
> Fixes: 3ad31d8a0df2 ("perf evsel: Centralize perf_sample initialization")
> Signed-off-by: Yang Jihong <yangjihong1@...wei.com>

Reviewed-by: Arnaldo Carvalho de Melo <acme@...hat.com>

- Arnaldo

> ---
>  tools/perf/util/evsel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 4d14f14f2506..a0f36a6b8a2d 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -2363,7 +2363,6 @@ int evsel__parse_sample(struct evsel *evsel, union perf_event *event,
>  	data->period = evsel->core.attr.sample_period;
>  	data->cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
>  	data->misc    = event->header.misc;
> -	data->id = -1ULL;
>  	data->data_src = PERF_MEM_DATA_SRC_NONE;
>  	data->vcpu = -1;
>  
> -- 
> 2.34.1
> 

-- 

- Arnaldo