linux-kernel - Re: [PATCH] thermal/drivers/tsens: Add suspend to RAM support for tsens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHLCerNx4KxzmQF8HmTTFr+W7xn5vubA=Jcg4Kwyk=cCJ4w+Wg@mail.gmail.com>
Date: Sun, 28 Jan 2024 01:41:10 +0530
From: Amit Kucheria <amitk@...nel.org>
To: Priyansh Jain <quic_priyjain@...cinc.com>
Cc: Konrad Dybcio <konrad.dybcio@...aro.org>, Thara Gopinath <thara.gopinath@...il.com>, 
	Bjorn Andersson <andersson@...nel.org>, "Rafael J . Wysocki" <rafael@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, 
	Lukasz Luba <lukasz.luba@....com>, linux-pm@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	quic_manafm@...cinc.com
Subject: Re: [PATCH] thermal/drivers/tsens: Add suspend to RAM support for tsens

On Wed, Jan 24, 2024 at 8:55 PM Priyansh Jain <quic_priyjain@...cinc.com> wrote:
>
>
>
> On 1/24/2024 6:04 PM, Konrad Dybcio wrote:
> >
> >
> > On 1/24/24 11:42, Priyansh Jain wrote:

> >>
> >> As part of suspend to RAM, tsens hardware will be turned off and it
> >> cannot generate any interrupt.Also system doesn't want to abort
> >> suspend to RAM due to tsens interrupts since system is already going
> >> into lowest
> >> power state. Hence disabling tsens interrupt during suspend to RAM
> >> callback.
> >
> > Is that a hardware limitation, or a software design choice? I'm not
> > sure I want my phone to have thermal notifications disabled when
> > it's suspended.
>
> > Konrad
>
> As part of suspend to RAM , entire SOC will be off, this mode (suspend
> to RAM) is not intended for Mobile product. Tsens interrupts are not
> disabled as part of suspend to idle(suspend mode for mobile).

You should hide the callbacks behind the CONFIG_SUSPEND Kconfig option
so that it only gets enabled when S2R is enabled.