linux-kernel - Re: [PATCH v3 2/2] hwmon: add fan speed monitoring driver for Surface devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 27 Jan 2024 15:28:28 -0500
From: Ivor Wanders <ivor@...nders.net>
To: w_armin@....de
Cc: corbet@....net,
	hdegoede@...hat.com,
	ivor@...nders.net,
	jdelvare@...e.com,
	linux-doc@...r.kernel.org,
	linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux@...ck-us.net,
	luzmaximilian@...il.com,
	markgross@...nel.org,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v3 2/2] hwmon: add fan speed monitoring driver for Surface devices

Hello Armin, thank you for your second review.

> maybe you can just return 0 here.
Good idea, that's indeed the only option for ret, so that makes it clearer.

> Maybe use PTR_ERR_OR_ZERO() here?
Definitely, thanks for suggesting this; cleans it up nicely.

~Ivor