linux-kernel - RE: [PATCH v2 4/6] pinctrl: Implementation of the generic scmi-pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 28 Jan 2024 00:28:42 +0000
From: Peng Fan <peng.fan@....com>
To: Linus Walleij <linus.walleij@...aro.org>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: Sudeep Holla <sudeep.holla@....com>, Cristian Marussi
	<cristian.marussi@....com>, Rob Herring <robh+dt@...nel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
	<conor+dt@...nel.org>, Oleksii Moisieiev <oleksii_moisieiev@...m.com>, Shawn
 Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
	dl-linux-imx <linux-imx@....com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, AKASHI Takahiro <takahiro.akashi@...aro.org>
Subject: RE: [PATCH v2 4/6] pinctrl: Implementation of the generic
 scmi-pinctrl driver

Hi Linus,

> Subject: Re: [PATCH v2 4/6] pinctrl: Implementation of the generic scmi-
> pinctrl driver
> 
> Hi Peng,
> 
> thanks for your patch!
> 
> On Thu, Jan 4, 2024 at 11:45 AM Peng Fan (OSS) <peng.fan@....nxp.com>
> wrote:
> 
> > From: Peng Fan <peng.fan@....com>
> >
> > scmi-pinctrl driver implements pinctrl driver interface and using SCMI
> > protocol to redirect messages from pinctrl subsystem SDK to SCMI
> > platform firmware, which does the changes in HW.
> >
> > Co-developed-by: Oleksii Moisieiev <oleksii_moisieiev@...m.com>
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@...m.com>
> > Signed-off-by: Peng Fan <peng.fan@....com>
> (...)
> > +#ifdef CONFIG_OF
> > +       .dt_node_to_map = pinconf_generic_dt_node_to_map_all,
> > +       .dt_free_map = pinconf_generic_dt_free_map, #endif
> 
> This looks like with !OF the driver becomes pretty unusable doesn't it?
> 
> Should we just depend on OF in Kconfig or are there already plans for ACPI or
> similar?

I not have platforms that has ACPI support. Cristian, Sudeep do you have
plans?

I could add depends on OF in V4, since current patch version is
https://lore.kernel.org/all/20240121-pinctrl-scmi-v3-4-8d94ba79dca8@nxp.com/

or I could use a follow up patch after V4 patch 1-4 applied.

Would you ACK the current V3 patch or wait I add OF dependency?

Thanks,
Peng.

> 
> Yours,
> Linus Walleij