linux-kernel - Re: [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbYYtx7-Z-A07K4N@krava>
Date: Sun, 28 Jan 2024 10:04:55 +0100
From: Jiri Olsa <olsajiri@...il.com>
To: Menglong Dong <dongmenglong.8@...edance.com>
Cc: andrii@...nel.org, ast@...nel.org, daniel@...earbox.net,
	john.fastabend@...il.com, martin.lau@...ux.dev, eddyz87@...il.com,
	song@...nel.org, yonghong.song@...ux.dev, kpsingh@...nel.org,
	sdf@...gle.com, haoluo@...gle.com, bpf@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf: remove unused field "mod" in struct
 bpf_trampoline

On Sun, Jan 28, 2024 at 01:54:43PM +0800, Menglong Dong wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
> 
> Signed-off-by: Menglong Dong <dongmenglong.8@...edance.com>

Fixes: 31bf1dbccfb0 ("bpf: Fix attaching fentry/fexit/fmod_ret/lsm to modules")

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka


> ---
>  include/linux/bpf.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index b86bd15a051d..1ebbee1d648e 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -1189,7 +1189,6 @@ struct bpf_trampoline {
>  	int progs_cnt[BPF_TRAMP_MAX];
>  	/* Executable image of trampoline */
>  	struct bpf_tramp_image *cur_image;
> -	struct module *mod;
>  };
>  
>  struct bpf_attach_target_info {
> -- 
> 2.39.2
>