linux-kernel - Re: [PATCH] usb: dwc3-of-simple: Stop using of_reset_control_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024012705-rabid-slighting-8d50@gregkh>
Date: Sat, 27 Jan 2024 16:38:11 -0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Felipe Balbi <balbi@...nel.org>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3-of-simple: Stop using
 of_reset_control_array_get() directly

On Sat, Jan 27, 2024 at 04:34:14PM -0800, Greg Kroah-Hartman wrote:
> On Wed, Jan 24, 2024 at 01:56:18PM +0100, Philipp Zabel wrote:
> > On Mi, 2024-01-24 at 04:39 -0800, Greg Kroah-Hartman wrote:
> > > On Wed, Jan 24, 2024 at 12:26:20PM +0100, Philipp Zabel wrote:
> > > > Use of_reset_control_array_get_optional_exclusive() instead, it is
> > > > implemented as:
> > > > 
> > > >   static inline struct reset_control *
> > > >   of_reset_control_array_get_optional_exclusive(struct device_node *node)
> > > >   {
> > > >           return of_reset_control_array_get(node, false, true, true);
> > > >   }
> > > > 
> > > > This makes the code easier to understand and removes the last remaining
> > > > direct use of of_reset_control_array_get(). No functional changes.
> > > > 
> > > > Fixes: f4cc91ddd856 ("usb: dwc3: of-simple: remove Amlogic GXL and AXG compatibles")
> > > 
> > > No functional change, but a Fixes: tag?  That doesn't make sense to me,
> > > sorry.
> > 
> > The referenced patch made the boolean parameters const but missed that
> > there is a static inline wrapper for this combination. I can drop the
> > Fixes: tag and describe this in the text.
> 
> That would be best, thanks.

Ah you already did so, thanks!